Use pthread_equal for pthread_t comparison #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Aug 24, 2021
lrstewart
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Fixes issues called out in: #3011
Description of changes:
Per the documentation, it is not correct to compare
pthread_tvalues with==,pthread_equalis the correct API.Call-outs:
Had to add a separate
boolto denote initialization vias2n_init, as there is no defined invalid value forpthread_t. No implementation currently ever returns 0 for a thread ID, but that doesn't mean they can't.Testing:
Tested downstream in the use-cases that necessitated the original changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.