refactor: move s2n_result functions inline #4739
Conversation
camshaft
changed the title
| /* | ||
| * The goal of s2n_result is to provide a strongly-typed error | ||
| * signal value, which provides the compiler with enough information |
There was a problem hiding this comment.
Nit: I think we generally put big comments like this after the includes, rather than before? But idk, we don't have many examples :)
There was a problem hiding this comment.
not sure i agree with that convention. Why wouldn't the module-level documentation be the first thing, since it's the first thing you read to understand why the module exists? Why would includes be first?
Not offhand but I can try to get some if you'd like, though it may take a bit of effort. Actually, the reason I'm making this change now is to simplify the fuzz test work that @jouho is working on - we were running into issues building the LD_PRELOAD |
Description of changes:
This change moves all of the
s2n_resultfunctions into thes2n_result.hfile. All of these functions consist of a single expression and prevent potential optimizations without LTO being enabled. All of these functions arestatic inlineto avoid duplicate symbols.Testing:
Since this is a simple refactor, no additional testing is needed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.