feat: Reworking cleanup behavior #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
force-pushed
the
cleanup
branch
2 times, most recently
from
0392a51
to
6d23b13
Compare
maddeleine
commented
Nov 7, 2024
| * s2n_cleanup will only perform a complete cleanup if the atexit handler | ||
| * is disabled and s2n_cleanup is called by the thread that called s2n_init. | ||
| * Therefore s2n_cleanup_final should be used instead of s2n_cleanup in cases | ||
| * where the user needs full control over when the complete cleanup executes. |
There was a problem hiding this comment.
I am deleting this paragraph because s2n_cleanup no longer performs a full cleanup so most of this information is incorrect.
lrstewart
reviewed
Nov 8, 2024
goatgoose
reviewed
Nov 8, 2024
lrstewart
reviewed
Nov 11, 2024
goatgoose
approved these changes
Nov 11, 2024
lrstewart
approved these changes
Nov 11, 2024
dougch
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
This change disables the atexit handler by default in our library.
Call-outs:
I am not disabling the atexit handler in our unit tests. If I remove it there then we get a huge amount of memory leaks and then PR to fix them becomes gigantic.
Testing:
CI should pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.