Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for inf spec and server override to be passed #4769

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

samruds
Copy link
Collaborator

@samruds samruds commented Jul 3, 2024

Issue #, if available:

Fix check to allow for server override and inf spec

Description of changes:
Update validation

Testing done:
Added UT

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samruds samruds requested a review from a team as a code owner July 3, 2024 06:31
@samruds samruds requested a review from ptkab July 3, 2024 06:31
@samruds samruds requested review from makungaj1 and removed request for ptkab July 3, 2024 06:31
@samruds samruds changed the title fix: allow for just inf spec and server overide to be passed fix: allow for inf spec and server override to be passed Jul 3, 2024
@zhaoqizqwang zhaoqizqwang merged commit 3d1a4f7 into aws:master Jul 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants