Add an option in local model trainer to remove inputs and container artifacts #4978
+146
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using local model trainer
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
had a problem deploying
to
auto-approve
GitHub Actions
Error
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
| @@ -203,6 +203,8 @@ class ModelTrainer(BaseModel): | |||
| local_container_root (Optional[str]): | |||
| The local root directory to store artifacts from a training job launched in | |||
| "LOCAL_CONTAINER" mode. | |||
| remove_inputs_and_container_artifacts (Optional[bool]): | |||
There was a problem hiding this comment.
This option seems to be specifically for local mode? Can we not just do the cleanup for local mode by default?
We should be very careful in expanding the input param list for ModelTrainer (we shouldn't unless User experience warrants it).
There was a problem hiding this comment.
+1
Is there any advantage we provide by keeping the artifacts stored?
There was a problem hiding this comment.
the users may need to check the environment variables and hyperparameters in each container to debug
nargokul
requested changes
Dec 26, 2024
| @@ -108,6 +108,8 @@ class _LocalContainer(BaseModel): | |||
| container_entrypoint: Optional[List[str]] | |||
| container_arguments: Optional[List[str]] | |||
|
|
|||
| _temperary_folders: List[str] = [] | |||
| @@ -203,6 +203,8 @@ class ModelTrainer(BaseModel): | |||
| local_container_root (Optional[str]): | |||
| The local root directory to store artifacts from a training job launched in | |||
| "LOCAL_CONTAINER" mode. | |||
| remove_inputs_and_container_artifacts (Optional[bool]): | |||
There was a problem hiding this comment.
+1
Is there any advantage we provide by keeping the artifacts stored?
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using local model trainer
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.