Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affinity to Helm chart #237

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add affinity to Helm chart #237

merged 3 commits into from
Jul 10, 2023

Conversation

dongheeJeong
Copy link
Contributor

Issue #, if available:
Not available.

Description of changes:
Add affinity to Helm chart.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@goyalya
Copy link

goyalya commented Jun 26, 2023

Thank you for submitting the request. Could you please elaborate on the need to add Affinity option ?

@dongheeJeong
Copy link
Contributor Author

dongheeJeong commented Jul 3, 2023

@goyalya

As EKS Fargate does not support daemonset, to not schedule daemonset pod to Fargate node, affinity is required like this.

@simonmarty simonmarty mentioned this pull request Jul 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #237 (700207b) into main (84327a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   53.15%   53.15%           
=======================================
  Files           8        8           
  Lines         730      730           
=======================================
  Hits          388      388           
  Misses        332      332           
  Partials       10       10           

@danmancuso danmancuso self-requested a review July 10, 2023 19:06
@danmancuso danmancuso merged commit 52ce2ef into aws:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants