Helm: fix environment variables location #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables have to be set on container level
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 53.15% 53.15%
=======================================
Files 8 8
Lines 730 730
=======================================
Hits 388 388
Misses 332 332
Partials 10 10 ☔ View full report in Codecov by Sentry. |
simonmarty
approved these changes
Mar 27, 2024
joebaro
approved these changes
Mar 27, 2024
nlamirault
added a commit
to nlamirault/secrets-store-csi-driver-provider-aws
that referenced
this pull request
Jun 10, 2024
* main: (41 commits) Increment helm chart version number Update image tag (aws#355) Update to Go 1.21 (aws#353) Bump golang.org/x/net from 0.20.0 to 0.23.0 (aws#341) Helm: fix environment variables location (aws#332) Update the version of the image (aws#331) Fix support for non-default kubelet root directory (aws#330) Increase the version to 0.3.8 Make throttling params QPS and Burst configurable (aws#323) Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (aws#325) Add support for non-default kubelet root directory (aws#322) Allow users to configure the underlying AWS SDK to enable FIPS endpoint (aws#324) STS VPC endpoint for private clusters (aws#319) Update to secrets-store.csi.x-k8s.io/v1 (aws#317) Update CODEOWNERS Update helm chart to version 0.3.6 (aws#309) Move to Go 1.20 (aws#303) Version bump (aws#297) Update dependencies (aws#296) Clarify requirement for EC2 on EKS (aws#275) ... Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix daemonset.yaml to ensure that environment variables have to be set on container level
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.