Add intrinsic support for Serverless::Function.DeploymentPreference.Enabled #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 94.36% 94.22% -0.15%
==========================================
Files 71 71
Lines 3621 3635 +14
Branches 713 717 +4
==========================================
+ Hits 3417 3425 +8
- Misses 104 108 +4
- Partials 100 102 +2
Continue to review full report at Codecov.
|
Serverless::Function.DeploymentPreference.Enabled
keetonian
approved these changes
Oct 17, 2019
keetonian
assigned praneetap and ShreyaGangishetty and unassigned keetonian and praneetap
ShreyaGangishetty
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
@eddiecho Thank you for contributing this! This looks good to me
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add intrinsic support for Serverless::Function.DeploymentPreference.Enabled
Issue #, if available:
Description of changes:
Added intrinsics for Serverless::Function.DeploymentPreferences.Enabled. It now supports Fn::If, Fn::FindInMap, !Ref, etc.
Description of how you validated changes:
Wrote/updated unit tests validating the changes. Tested changes with a production template to verify changes manually.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.