Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VPC Access Policy when VpcConfig is present #1228

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

eugeniosu
Copy link
Contributor

@eugeniosu eugeniosu commented Oct 29, 2019

Issue #, if available:
#1169

Description of changes:
The managed policy service-role/AWSLambdaVPCAccessExecutionRole is added when the property VpcConfig is present .

Description of how you validated changes:
I updated the tests to check that the generated role contains service-role/AWSLambdaVPCAccessExecutionRole

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1228 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1228      +/-   ##
===========================================
+ Coverage    94.48%   94.49%   +<.01%     
===========================================
  Files           72       72              
  Lines         3738     3740       +2     
  Branches       740      741       +1     
===========================================
+ Hits          3532     3534       +2     
  Misses         104      104              
  Partials       102      102
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 95.65% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3725f00...972f058. Read the comment docs.

@eugeniosu eugeniosu marked this pull request as ready for review October 29, 2019 15:11
@ShreyaGangishetty ShreyaGangishetty self-assigned this Nov 1, 2019
@ShreyaGangishetty
Copy link

@eugeniosu Thank you contributing this!
Could you please resolve the merge conflicts and update the PR?

@ShreyaGangishetty ShreyaGangishetty changed the base branch from develop to master November 11, 2019 22:29
@ShreyaGangishetty ShreyaGangishetty changed the base branch from master to develop November 11, 2019 22:29
Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved the merge conflicts.
This PR looks good to me!

Copy link
Contributor

@praneetap praneetap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants