-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding VPC Access Policy when VpcConfig is present #1228
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1228 +/- ##
===========================================
+ Coverage 94.48% 94.49% +<.01%
===========================================
Files 72 72
Lines 3738 3740 +2
Branches 740 741 +1
===========================================
+ Hits 3532 3534 +2
Misses 104 104
Partials 102 102
Continue to review full report at Codecov.
|
@eugeniosu Thank you contributing this! |
e2e7f70
to
f47abe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have resolved the merge conflicts.
This PR looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Issue #, if available:
#1169
Description of changes:
The managed policy
service-role/AWSLambdaVPCAccessExecutionRole
is added when the propertyVpcConfig
is present .Description of how you validated changes:
I updated the tests to check that the generated role contains
service-role/AWSLambdaVPCAccessExecutionRole
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.