Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cloudwatch:describeAlarmHistory policy #1264

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

zmaleki
Copy link
Contributor

@zmaleki zmaleki commented Nov 26, 2019

Issue
#1265

Description of changes:
Added describe cloudwatch alarm history to list of policy templates.

Description of how you validated changes:

  • update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #1264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          71       71           
  Lines        3619     3619           
  Branches      714      714           
=======================================
  Hits         3417     3417           
  Misses        103      103           
  Partials       99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5720d...87d0aae. Read the comment docs.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, verified that Resource: * is required.

Thank you for this contribution!

@ShreyaGangishetty ShreyaGangishetty merged commit 7f3c203 into aws:master Dec 6, 2019
ShreyaGangishetty pushed a commit to ShreyaGangishetty/serverless-application-model that referenced this pull request Dec 6, 2019
ShreyaGangishetty pushed a commit to ShreyaGangishetty/serverless-application-model that referenced this pull request Dec 6, 2019
ShreyaGangishetty pushed a commit that referenced this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants