Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inbound-ses-spam-filter to include Lambda ARN #1294

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

dballance
Copy link
Contributor

Issue #, if available: N/A

Description of changes: Currently, this filter is pretty useless to deploy as a nested stack. I cannot use the published resource because I cannot tie the Function ARN to my SES ReceiptRuleAction. This change adds an output so that this template is useful for nested deployments.

Description of how you validated changes: No validation

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dballance dballance changed the title Add Lambda ARN Ouput Update inbound-ses-spam-filter to include Lambda ARN Dec 5, 2019
@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #1294 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1294   +/-   ##
=======================================
  Coverage     94.5%   94.5%           
=======================================
  Files           72      72           
  Lines         3746    3746           
  Branches       742     742           
=======================================
  Hits          3540    3540           
  Misses         104     104           
  Partials       102     102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56a09d...736f980. Read the comment docs.

@ShreyaGangishetty ShreyaGangishetty self-assigned this Dec 5, 2019
@keetonian
Copy link
Contributor

Thank you for contributing this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants