-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AutoPublishCodeSha256 to allow overriding the publish versi… #1376
Conversation
019caa5
to
0cd9997
Compare
…on resource identifier
0cd9997
to
eca5538
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1376 +/- ##
===========================================
+ Coverage 94.46% 94.47% +<.01%
===========================================
Files 78 78
Lines 4555 4559 +4
Branches 912 913 +1
===========================================
+ Hits 4303 4307 +4
Misses 118 118
Partials 134 134
Continue to review full report at Codecov.
|
@@ -70,6 +70,7 @@ class SamFunction(SamResourceMacro): | |||
"EventInvokeConfig": PropertyType(False, is_type(dict)), | |||
# Intrinsic functions in value of Alias property are not supported, yet | |||
"AutoPublishAlias": PropertyType(False, one_of(is_str())), | |||
"AutoPublishCodeSha256": PropertyType(False, one_of(is_str())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Just is_str() instead of one_of(is_str())
Thanks @praneetap this
Is this live and ready for testing yet, or is there a new transform that is required to support this? Also does the value passed to |
This issue was related to passing in a |
Issue #, if available: #1375
Description of changes: The change introduces additional attribute to AWS::Serverless::Function that allow to override the hash computed for the created Lambda version. To allow more fine grained control this change adds a
AutoPublishCodeSha256
attribute that will allow to associate it in the template.Example:
Description of how you validated changes: Added unit tests to cover this feature.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.