Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Only add labels on open of PRs #2225

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Nov 17, 2021

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Add/update tests using:
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #2225 (7e99631) into develop (e7a1496) will increase coverage by 0.96%.
The diff coverage is 98.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2225      +/-   ##
===========================================
+ Coverage    93.58%   94.54%   +0.96%     
===========================================
  Files           90       95       +5     
  Lines         6124     6566     +442     
  Branches      1260     1322      +62     
===========================================
+ Hits          5731     6208     +477     
+ Misses         183      166      -17     
+ Partials       210      192      -18     
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 93.10% <ø> (ø)
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø)
samtranslator/translator/logical_id_generator.py 100.00% <ø> (+9.09%) ⬆️
samtranslator/region_configuration.py 77.77% <63.63%> (-22.23%) ⬇️
samtranslator/swagger/swagger.py 94.02% <94.23%> (+0.66%) ⬆️
samtranslator/model/api/api_generator.py 94.69% <96.55%> (+0.33%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/intrinsics/actions.py 98.75% <100.00%> (+0.03%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d641b...7e99631. Read the comment docs.

@jfuss jfuss merged commit 2fd3bec into aws:develop Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants