Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open api set_path_default_authorizer #2246

Closed
wants to merge 1 commit into from

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Nov 25, 2021

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Add/update tests using:
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #2246 (c66e9ab) into develop (e7a1496) will increase coverage by 0.77%.
The diff coverage is 98.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2246      +/-   ##
===========================================
+ Coverage    93.58%   94.36%   +0.77%     
===========================================
  Files           90       95       +5     
  Lines         6124     6598     +474     
  Branches      1260     1331      +71     
===========================================
+ Hits          5731     6226     +495     
+ Misses         183      178       -5     
+ Partials       210      194      -16     
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 93.10% <ø> (ø)
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø)
samtranslator/translator/logical_id_generator.py 100.00% <ø> (+9.09%) ⬆️
samtranslator/region_configuration.py 77.77% <63.63%> (-22.23%) ⬇️
samtranslator/model/api/api_generator.py 93.24% <90.00%> (-1.13%) ⬇️
samtranslator/model/eventsources/pull.py 92.89% <97.77%> (+14.20%) ⬆️
samtranslator/swagger/swagger.py 93.27% <98.03%> (-0.09%) ⬇️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e816e50...c66e9ab. Read the comment docs.

@mndeveci mndeveci changed the base branch from develop to hotfix/11252021 November 25, 2021 23:47
@mndeveci mndeveci changed the base branch from hotfix/11252021 to develop November 25, 2021 23:47
@mndeveci
Copy link
Contributor

Updated here; #2248

@mndeveci mndeveci closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants