Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise Invalid Resource When DisableExecuteApiEndpoint: False And Has No DefinitionBody #2285

Merged
merged 7 commits into from
Jan 21, 2022

Conversation

CoshUS
Copy link
Contributor

@CoshUS CoshUS commented Jan 10, 2022

Issue #, if available:
When DisableExecuteApiEndpoint is False, http api and api generator will treat it as None which means the default, True.

Description of changes:

Description of how you validated changes:

Checklist:

  • Add/update tests using:
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #2285 (b33373d) into develop (e7a1496) will increase coverage by 0.86%.
The diff coverage is 97.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2285      +/-   ##
===========================================
+ Coverage    93.58%   94.45%   +0.86%     
===========================================
  Files           90       97       +7     
  Lines         6124     7084     +960     
  Branches      1260     1433     +173     
===========================================
+ Hits          5731     6691     +960     
+ Misses         183      179       -4     
- Partials       210      214       +4     
Impacted Files Coverage Δ
samtranslator/model/api/http_api_generator.py 91.89% <77.77%> (+0.70%) ⬆️
samtranslator/model/api/api_generator.py 94.03% <92.72%> (-0.33%) ⬇️
samtranslator/model/apigateway.py 96.95% <96.00%> (-0.20%) ⬇️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/intrinsics/actions.py 98.79% <100.00%> (+0.07%) ⬆️
samtranslator/metrics/method_decorator.py 100.00% <100.00%> (ø)
samtranslator/metrics/metrics.py 100.00% <100.00%> (ø)
samtranslator/model/__init__.py 97.64% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6943a...b33373d. Read the comment docs.

bin/sam-translate.py Outdated Show resolved Hide resolved
bin/sam-translate.py Show resolved Hide resolved
@CoshUS CoshUS requested a review from hawflau January 17, 2022 18:15
@hawflau hawflau merged commit 7eb3587 into aws:develop Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants