Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test for DefaultAuthorizers not a string in API #2313

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Feb 5, 2022

In issue #1245, we had a cases were SAM would fail due to improper validation.
In updating #1286, I noticed this was patched in #1774 but we only added tests
for AWS::Serverless::StateMachine. This commit adds an additional test to cover
AWS::Serverless::Api.

Issue #, if available:
n/a but is a test to cover #1245

Description of changes:
Adds additional test

Description of how you validated changes:
make pr ran successfully

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In issue aws#1245, we had a cases were SAM would fail due to improper validation.
In updating aws#1286, I noticed this was patched in aws#1774 but we only added tests
for AWS::Serverless::StateMachine. This commit adds an additional test to cover
AWS::Serverless::Api.
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #2313 (bdf5286) into develop (e7a1496) will increase coverage by 0.89%.
The diff coverage is 98.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2313      +/-   ##
===========================================
+ Coverage    93.58%   94.47%   +0.89%     
===========================================
  Files           90       97       +7     
  Lines         6124     7061     +937     
  Branches      1260     1435     +175     
===========================================
+ Hits          5731     6671     +940     
+ Misses         183      177       -6     
- Partials       210      213       +3     
Impacted Files Coverage Δ
samtranslator/model/api/api_generator.py 94.38% <92.95%> (+0.02%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/intrinsics/actions.py 98.78% <100.00%> (+0.06%) ⬆️
samtranslator/intrinsics/resource_refs.py 95.83% <100.00%> (-0.17%) ⬇️
samtranslator/metrics/method_decorator.py 100.00% <100.00%> (ø)
samtranslator/metrics/metrics.py 100.00% <100.00%> (ø)
samtranslator/model/__init__.py 97.63% <100.00%> (-0.02%) ⬇️
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521abe3...bdf5286. Read the comment docs.

@jfuss jfuss merged commit b1b3a9c into aws:develop Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants