Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this repo did not do any linting. The linting that is enabled
is basic, as this commit disables all of what pylint was complaining about.
Issue #, if available:
Linting was not done on commits, this update changes this. The
.pylintrc
file was copied from our other repos (aws-sam-cli) that we maintain.Description of changes:
Add linting and make linting run on
make pr
.I will make this more useful to us in the near future by fixing some of the smaller issues and likely just forcing pylint to ignore the rest. That way new code is always linted and we can work on removing/update the "legacy" code to be cleaner.
Description of how you validated changes:
Ran
make pr
Checklist:
make pr
passesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.