Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable pylint on project #2326

Merged
merged 1 commit into from
Feb 16, 2022
Merged

chore: Enable pylint on project #2326

merged 1 commit into from
Feb 16, 2022

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Feb 15, 2022

Previously, this repo did not do any linting. The linting that is enabled
is basic, as this commit disables all of what pylint was complaining about.

Issue #, if available:
Linting was not done on commits, this update changes this. The .pylintrc file was copied from our other repos (aws-sam-cli) that we maintain.

Description of changes:
Add linting and make linting run on make pr.

I will make this more useful to us in the near future by fixing some of the smaller issues and likely just forcing pylint to ignore the rest. That way new code is always linted and we can work on removing/update the "legacy" code to be cleaner.

Description of how you validated changes:
Ran make pr

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Previously, this repo did not do any linting. The linting that is enabled
is basic, as this commit disables all of what pylint was complaining about.
@jfuss jfuss merged commit 059b082 into aws:develop Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants