Fix warning when using default stage name and FailOnWarnings is on #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Dec 14, 2022
hoffa
reviewed
Dec 14, 2022
hoffa
reviewed
Dec 14, 2022
acristin
approved these changes
Dec 14, 2022
hoffa
reviewed
Dec 14, 2022
aahung
approved these changes
Dec 14, 2022
hoffa
approved these changes
Dec 14, 2022
…avinZZ/serverless-application-model into default_stage_name_with_failonwarnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#2297
Description of changes
Before the change, when we turn on
FailOnWarningsflag and use a default stage name, the deployment will fail because it will generate a warning sayingDescription of how you validated changes
Added integ test and ran all unit tests.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.