Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move some PullEventSource validations to subclasses #2767

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Jan 5, 2023

Issue #, if available

When I am using DynamoDB event, the mentioning of "MSK" in the error message is not helpful.

Description of changes

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung marked this pull request as ready for review January 5, 2023 01:10
@aahung aahung requested a review from a team as a code owner January 5, 2023 01:10
@aahung aahung force-pushed the separate-pull-validation branch from f73aa0e to a585478 Compare January 5, 2023 01:16
@aahung aahung enabled auto-merge (squash) January 5, 2023 01:30
@aahung aahung merged commit 5324ec0 into aws:develop Jan 5, 2023
@aahung aahung deleted the separate-pull-validation branch January 5, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants