-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do not install “schema_source” to site-packages #2973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. How did you spot this?
Nice, thanks! |
@musicinmybrain does this block samtranslator from going into https://src.fedoraproject.org/rpms/python-aws-sam-translator? |
I was working on updating the Fedora Linux package to 1.60.0, and when I did a test build, RPM produced an error due to installed-but-unpackaged files and directories (that is, ones not mentioned in the spec file’s |
What do you mean by block samtranslator from going into it? I plan to apply the PR as a downstream patch until it is present in a future release, which will allow me to update the Fedora package to 1.60.0 and beyond. (At least, I can update it for the upcoming F38 release and development/Rawhide branch; stable Fedora releases usually get stuck on a particular version after a while due to dependency issues.) Is that what you were asking? |
Thanks for following up on this so quickly, by the way. |
I see, good to know. I am interested in similar check directly in sam-translator GH repo. Thanks for the info and the PR.
yeah, glad it doesn't block that. |
Issue #, if available
None, but see #2825 (comment).
Description of changes
Adds
"schema_source"
and"schema_source.*"
to theexcludes
for the call tofind_packages
insetup.py
. Fixes unintentional installation of the newschema_source
directory intosite-packages
since 1.60.0.Since
black
now wraps the line anyway, alphabetize the excludes for easier examination.Description of how you validated changes
Applied as a downstream patch in Fedora Linux’s
python-aws-sam-translator
package, where I originally discovered the prpblem.Checklist
Examples?
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.