feat: Add a new property SeparateRecordSetGroup to disable merging into record set group
#2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssenchenko
reviewed
Mar 3, 2023
hoffa
reviewed
Mar 3, 2023
xazhao
changed the title
aahung
reviewed
Mar 14, 2023
hoffa
reviewed
Mar 15, 2023
hoffa
reviewed
Mar 15, 2023
hoffa
reviewed
Mar 15, 2023
hoffa
reviewed
Mar 15, 2023
hoffa
reviewed
Mar 15, 2023
hoffa
reviewed
Mar 16, 2023
hoffa
reviewed
Mar 16, 2023
hoffa
reviewed
Mar 16, 2023
hoffa
reviewed
Mar 16, 2023
hoffa
reviewed
Mar 16, 2023
hoffa
changed the title
SeparateRecordSetGroup to disable merging into record set group
hoffa
approved these changes
Mar 16, 2023
aahung
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Following up change of #2408
When there are multiple APIs share the same
HostedZoneId, the router53 record set will be merged into a record set group. AConditionin one of the APIs could be overrode in merging process.With the new property
SeparateRecordSetsunder Route53, users can assign to differentConditions to each API so it's more flexible.Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.