Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add skip_using_service_detector to sns integ tests #3016

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Mar 10, 2023

Issue #, if available

Description of changes

Follow up of #3015

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung requested a review from a team as a code owner March 10, 2023 22:30
@aahung aahung enabled auto-merge (squash) March 10, 2023 22:36
@aahung aahung merged commit 699882e into aws:develop Mar 10, 2023
@aahung aahung deleted the add-filter-policy-test-detector branch March 10, 2023 22:37
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, but I do prefer using the @skipIf annotation to make it clear when reading which tests should run when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants