feat: Support Ignore Globals resource attribute #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssenchenko
approved these changes
Oct 19, 2023
GavinZZ
force-pushed
the
ignore_globals
branch
from
ceac73d to
ead1a95
Compare
GavinZZ
changed the title
GavinZZ
force-pushed
the
ignore_globals
branch
2 times, most recently
from
1e9c634 to
1214037
Compare
GavinZZ
force-pushed
the
ignore_globals
branch
from
1214037 to
34d0549
Compare
ConnorRobertson
approved these changes
Oct 20, 2023
paulhcsun
reviewed
Oct 20, 2023
paulhcsun
approved these changes
Oct 20, 2023
xazhao
reviewed
Oct 20, 2023
xazhao
approved these changes
Oct 20, 2023
|
Hello @GavinZZ thank you for this feature we are wondering when this change will be rolled out, looking at the commit history looks like this is not part of the latest release? |
|
@tirumerla This change should be rolling out by end of this week with the next release v1.81. |
|
https://github.com/aws/serverless-application-model/releases/tag/v1.81.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#1874
Description of changes
Introduce
IgnoreGlobalsproperty on SAM Function. It's default to false, but when set to true, it will ignore the Function globals section.Description of how you validated changes
All existing and new tests pass
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.