Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message when JwtConfiguration is not a map #3567

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

aaythapa
Copy link
Contributor

Issue #, if available

Description of changes

Add an error message for when JwtConfiguration property not set to a map. Right now the error message is confusing

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaythapa aaythapa marked this pull request as ready for review March 18, 2024 21:36
@aaythapa aaythapa requested a review from a team as a code owner March 18, 2024 21:36
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just merge after addressing Xia's comment

@aaythapa aaythapa merged commit 6d3b39f into aws:develop Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants