Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new partition to arn generation #3574

Merged
merged 4 commits into from
Apr 3, 2024
Merged

fix: add new partition to arn generation #3574

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b42dc1f
add new partition to arn generator
aaythapa Apr 3, 2024
c328b51
format fix
aaythapa Apr 3, 2024
981e4e1
format fix
aaythapa Apr 3, 2024
16897fe
remove unused code
aaythapa Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samtranslator/translator/arn_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def _region_to_partition(region: str) -> str:
"us-isob": "aws-iso-b",
"us-gov": "aws-us-gov",
"eu-isoe": "aws-iso-e",
"us-isof": "aws-iso-f",
aaythapa marked this conversation as resolved.
Show resolved Hide resolved
}
for key, value in region_to_partition_map.items():
if region_string.startswith(key):
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/test_arn_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def setUp(self):
("us-isob-east-1", "aws-iso-b"),
("eu-isoe-west-1", "aws-iso-e"),
("US-EAST-1", "aws"),
("us-isof-east-1", "${AWS::Partition}"),
("us-isof-east-1", "aws-iso-f"),
]
)
def test_get_partition_name(self, region, expected):
Expand Down