Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change endpoint configuration for state machine integ test #3614

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Jun 17, 2024

Issue #, if available

N/A

Description of changes

We've seen this test fail in a couple of regions with the error Request to ... failed with status: 403, expected status: 200. This is also a known flaky test which we've seen fail before and succeed after a simple retry.

After investigation we concluded that the error is likely because the endpoint configuration is automatically set to EDGE which routes requests to a CloudFront Point of Presence. We suspect the test is calling the endpoint right after the stack is deployed but before the routing can take place. To mitigate this we set the endpoint configuration to REGIONAL for now.

Description of how you validated changes

Ran the test locally, it deployed and everything passed as before.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaythapa aaythapa marked this pull request as ready for review June 17, 2024 21:06
@aaythapa aaythapa requested a review from a team as a code owner June 17, 2024 21:06
Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment related to logging the headers

@aaythapa aaythapa enabled auto-merge (squash) June 17, 2024 22:30
@aaythapa aaythapa merged commit c64c882 into aws:develop Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants