Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Managed Policy ARNs with hardcoded partition in tests #3662

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

samson-keung
Copy link
Contributor

Issue #, if available

None

Description of changes

In some of the integ test templates, for managed policies, it is using an ARN with hardcoded AWS partition. This will fail the test in some regions, hence, replacing the partition part with the AWS::Partition parameter. Example of other places where this is already done.

Description of how you validated changes

Followed the other places in the code where this is already done

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samson-keung samson-keung requested a review from a team as a code owner October 10, 2024 17:54
@samson-keung samson-keung merged commit 8de1ca9 into aws:develop Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants