Enhance CompatibleRuntimes property of AWS::Serverless::LayerVersion

[systemdesignpartners]

Allow it to accept a !Ref to a String whereas currently it requires a List

Bugfix for Issue #809

Hopefully this addresses the minor enhancement I suggested in #809, which is to allow CompatibleRuntimes to be supplied by a String Parameter instead of insisting on a List. My first time looking at this codebase so buyer beware :)
Thanks
Tony

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-io]

Codecov Report

Merging #810 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #810   +/-   ##
=======================================
  Coverage     94.8%   94.8%           
=======================================
  Files           69      69           
  Lines         3079    3079           
  Branches       580     580           
=======================================
  Hits          2919    2919           
  Misses          84      84           
  Partials        76      76

Impacted Files	Coverage Δ
samtranslator/model/lambda_.py	88.46% <ø> (ø)	⬆️
samtranslator/model/sam_resources.py	95.5% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d1ed7...c67f9b5. Read the comment docs.

[brettstack]

Please delete the .swp files also

[keetonian]

Could you submit this PR against the develop branch? Thanks

[systemdesignpartners]

Branch is now up to date with 'origin/develop'

[jlhood]

@systemdesignpartners If you rebased your changes onto develop locally, you'll need to push them to your remote in order for them to be reflected in this PR. Also, please change the base on this PR to point to develop branch instead of master as well (click edit button at the top of the PR to select the base branch).

[systemdesignpartners]

Should be good on the rebase to develop. I added several test cases but unfortunately could not get some nice-to-haves to work, such as supplying a list of !Refs to CompatibleRuntimes, so I left it out.

[keetonian]

Hey! Thanks for changing the base branch on this PR. Could you also rebase onto develop to resolve merge commits and remove some of the commits that are on master but not on develop?

Here are the commands to run:

git remote add upstream https://github.com/awslabs/serverless-application-model.git
git fetch upstream
git rebase upstream/develop 
git push -f

If you run into conflicts on rebase, here are additional instructions on how to resolve it: https://help.github.com/en/articles/resolving-merge-conflicts-after-a-git-rebase

[systemdesignpartners]

Think it worked. Not sure it’s what you wanted, just let me know. Thanks

…

On Feb 26, 2019, at 1:24 PM, Keeton Hodgson ***@***.***> wrote: Hey! Thanks for changing the base branch on this PR. Could you also rebase onto develop to resolve merge commits and remove some of the commits that are on master but not on develop? Here are the commands to run: git remote add upstream https://github.com/awslabs/serverless-application-model.git git fetch upstream git rebase upstream/develop git push -f If you run into conflicts on rebase, here are additional instructions on how to resolve it: https://help.github.com/en/articles/resolving-merge-conflicts-after-a-git-rebase — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jlhood]

@systemdesignpartners Thanks for the quick follow up! You rebased correctly, but your changes are failing in the CI build. If you run make pr it'll show you the failures to fix. Make the changes necessary to fix the failures, commit and push again to run the CI build again.

[atreyd]

Any idea by when these changes will be rolled out to SAM. ?

[keetonian]

Could you add a new section to the test that uses your new parameters and update the test outputs? This looks good otherwise 👍

  LayerWithRuntimesList:
    Type: 'AWS::Serverless::LayerVersion'
    Properties:
      ContentUri: s3://sam-demo-bucket/layer.zip
      CompatibleRuntimes:
        - !Ref LayerRuntimeString1
        - !Ref LayerRuntimeString2