DefinitionUri supports a relative path #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified documentation that DefinitionUri can support a relative path which is less steps than needing uploading the swagger definition to S3 first.
|
Thanks for the PR. So not quite. If you use the AWS CLI command Would it be better to just add a note below the table, explaining that if you use a relative path, you should use the CLI to package first? |
|
We want to keep this doc as source of truth for the SAM Spec which only supports S3 URI. So not taking this PR. |
mndeveci
pushed a commit
that referenced
this pull request
Nov 19, 2021
mndeveci
added a commit
that referenced
this pull request
Nov 23, 2021
hawflau
added a commit
that referenced
this pull request
Apr 6, 2022
* feat: Support for Lambda URL (#86) * feat: changed CorsConfig property to Cors (#89) * feat: add list of "unreleased" properties (#91) This change hides the unreleased properties from the "Globals" error message * Lambda URL integ test (#94) * remove functionUrlConfig from the unrelease properties (#97) * remove functionUrlConfig from the unrelease properties * updates * Function Url new changes (#109) * update to Function Url * first update * reverted to support autopublishing and added validation for AuthType values * adding Integration test * fix: fix paths IF intrinsic bug (#107) * fix: fix paths IF intrinsic bug * missed bit of code * add NoValue tests * review feedback and refactoring * naming fix * review feedback naming and comments * add missing test + add extra check for api key on tests * integration test updated (#122) Co-authored-by: jonife <79116465+jonife@users.noreply.github.com> Co-authored-by: Renato Valenzuela <37676028+valerena@users.noreply.github.com> Co-authored-by: Ruperto Torres <86501267+torresxb1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified documentation that DefinitionUri can support a relative path which is less steps than needing uploading the swagger definition to S3 first.