Update time parsing to not be as strict for HTTPDate and DateTime #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the parsing of HTTPDate and DateTime time formats to not be as strict, and allow more variants of the time format. Including UTC offsets for DateTime.
skmcgrail
approved these changes
Jun 15, 2021
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jun 16, 2021
Updates the SDK's parsing of IOS based datetime formats to support UTC offsets. Related to aws/smithy-go#307
skotambkar
reviewed
Jun 16, 2021
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jun 16, 2021
Updates the SDK's parsing of IOS based datetime formats to support UTC offsets. Related to aws/smithy-go#307
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jun 17, 2021
Updates the SDK's parsing of IOS based datetime formats to support UTC offsets. Related to aws/smithy-go#307
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jun 17, 2021
Updates the SDK's parsing of IOS based datetime formats to support UTC offsets. Related to aws/smithy-go#307
jasdel
added a commit
to aws/aws-sdk-go
that referenced
this pull request
Jun 17, 2021
…#3960) Updates the SDK's parsing of ISO8601 based datetime formats to support UTC offsets. Related to aws/smithy-go#307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the parsing of HTTPDate and DateTime time formats to not be as strict, and allow more variants of the time format. Including UTC offsets for DateTime.
Also updates the Format* methods of smithy-go/time package to always serialize the date as a UTC value. Without this, the value would be serialized as it is, dropping the UTC offset.
Updates the
transport/httppackage'sParseTimefunction to use the updatedtime.ParseHTTPDatefunction since they overlapped.Fixes #302 by changing time to UTC before formatting so no local offset time is lost.