Update intEnum generation to use type alias #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to type definitions requiring strict casting and implementation overhead in protocol generation, this commit uses type aliases to generate intEnums as an intermediate step until migrating back to type definitions. This change is backwards compatible except for the removed `Values()` method that was on intEnum type definitions, but not definable on type aliases since defining methods on base types (`int32`) is not permitted.
isaiahvita
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Due to type definitions requiring strict casting and implementation
overhead in protocol generation, this commit uses type aliases to
generate intEnums as an intermediate step until migrating back to
type definitions.
This change is backwards compatible except for the removed
Values()method that was on intEnum type definitions, but not definable on type
aliases since defining methods on base types (
int32) is not permitted.Note: No AWS services use the intEnum shape YET, so for aws-sdk-go-v2, it is backwards compatible.
Testing:
Temporarily change all repo smithy versions to 1.28.0 (not published at the time of the PR).
./gradlew clean build check publishToMavenLocalusing this PR: Update protocol tests with int enum coverage smithy-lang/smithy#1492make smithy-clean smithy-build smithy-publish-local smithy-cleanmakeMakefile-fail-fast=falseBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.