Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated X-Ray Lambda function segment section #170

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

willarmiros
Copy link
Contributor

@willarmiros willarmiros commented Mar 23, 2020

Description of changes:
Corrected the following items:

  1. Include HTTP requests in "downstream calls" subsegments that are available
  2. Removes the claim that you can add annotations to the function segment; this is not possible
  3. Removes the claim that you need to use the X-Ray SDK to emit segments.

I also added an explanation of the behavior X-Ray exhibits when customers try to create custom segments in Lambda function code. It is a very common question (e.g. here and here and here). Happy to link X-Ray SDK docs or make other changes where necessary.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mwunderl mwunderl merged commit e8d13db into awsdocs:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants