Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KS covariate shift detector #242

Merged
merged 13 commits into from
May 23, 2023
Merged

Add KS covariate shift detector #242

merged 13 commits into from
May 23, 2023

Conversation

lballes
Copy link
Contributor

@lballes lballes commented May 23, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lballes lballes marked this pull request as ready for review May 23, 2023 10:20
@lballes lballes requested a review from 610v4nn1 May 23, 2023 10:20
@github-actions
Copy link

Coverage report

The coverage rate went from 85.68% to 85.76% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

src/renate/shift/ks_detector.py

100% of new lines are covered (100% of the complete file).

]
# Bonferroni correction: Reject only if the minimal p-value among the multiple tests is
# lower than `alpha / num_tests`, where `alpha` is the significance level. Equivalently, we
# multiple the p-value by `num_tests`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: multiply

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in follow-up PR

@lballes lballes merged commit 944a23c into dev May 23, 2023
@lballes lballes deleted the lballes-ks-covshift branch May 23, 2023 12:07
lballes added a commit that referenced this pull request May 24, 2023
lballes added a commit that referenced this pull request May 24, 2023
* Add NLP Components to Benchmarking (#213)

* Robust Integration Tests (#214)

* Update Renate Config Example (#226)

* Make Wild Time Available in Benchmarking (#187)

* Fix `target_column` bug in `HuggingFaceTextDataModule` (#233)

* Add MMD covariate shift detector (#237)

* Add KS covariate shift detector (#242)

* Update dependabot.yml (#248)

* Update versions of some requirements (#247)

* Add doc page and example for shift detection (#244)

* Bump version (#252)

---------

Co-authored-by: Lukas Balles <lukas.balles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants