Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency and problem with import #272

Merged
merged 2 commits into from
May 31, 2023
Merged

Missing dependency and problem with import #272

merged 2 commits into from
May 31, 2023

Conversation

wistuba
Copy link
Contributor

@wistuba wistuba commented May 30, 2023

wild-time-data was automatically imported causing problems if it wasn't installed.
tensorboard(X) is a dependency we did not have in our requirements file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented May 30, 2023

Coverage report

The coverage rate went from 85.76% to 85.93% ⬆️

0% of new lines are covered.

Diff Coverage details (click to unfold)

src/renate/benchmark/datasets/wild_time_data.py

0% of new lines are covered (48.38% of the complete file).
Missing lines: 64, 65, 74, 86, 87

@wistuba wistuba requested a review from lballes May 30, 2023 15:07
@wistuba wistuba merged commit 25c9144 into dev May 31, 2023
@wistuba wistuba deleted the mw-fix-imports branch May 31, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants