Add Micro Average Accuracy #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)src/renate/benchmark/experimentation.py
src/renate/evaluation/metrics/classification.py
src/renate/utils/module.py
|
lballes
reviewed
Jul 26, 2023
| """ | ||
| data = [] | ||
| for task_id in range(num_tasks + 1): | ||
| for task_id in range(num_tasks): |
There was a problem hiding this comment.
Why did this change? I don't understand why it was num_tasks + 1 before, but this change doesn't seem related to the micro-average accuracy.
There was a problem hiding this comment.
Agreed, not related to micro average at all, just some clean up.
In L384 the -1 was removed so that would be the adequate change in this function.
lballes
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.