Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark made of multiple text datasets #354
Add benchmark made of multiple text datasets #354
Changes from 34 commits
19ee3d5
a00ed47
fe325e8
b21c0b4
0dd1618
2198d2a
c4404a9
15c0745
cb4d723
ef956b3
2d3de75
5eac7fc
d5c8333
4048350
6f81901
015ef3f
dc5d80e
63ca3a6
0b9a90b
1bfbc4d
7bc816b
678a4a7
d31a13a
0bd72ec
bf2f8f2
cb6fe3b
df4d172
5060e79
d001151
e7985ec
ca1c526
9f11751
56bb55a
8452b84
9c26c1a
c82285e
3b009a7
1ad978e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the intuition of selecting a subset for this specific dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set a relatively small value by default because I expect it to be closer to the actual usage than the max value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is a copy needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
names still imply that they are generally used. I was thinking more something along the lines of
MULTI_TEXT_TRAIN_SET_SIZE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer no to have per-dataset default training/test set size