Support Use of Joint and GDumb with Pre-Trained Models #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joint and Gdumb reset the models
on_model_update_start
. This results in a non-desired behavior when working with pre-trained models.There is also no option to not reset the model at all.
The change introduces a new flag
reset
which allows to control whether the model will be reset. Furthermore, in case of a reset, the pre-trained model will be reloaded instead of using an untrained model.The integration tests are expected to break for Joint and GDumb due to a different initialization of the model. Before, the workflow was creating the model and resetting it. Now, it only creates the model without reset.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.