Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes #450

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Documentation changes #450

merged 3 commits into from
Oct 9, 2023

Conversation

prabhuteja12
Copy link
Contributor

Adds CDDB, Core50, L2P documentation on the benchmarks listing page.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Coverage report

Note

Coverage evolution disabled because this PR targets a different branch
than the default branch, for which coverage data is not available.

The coverage rate is 82.66%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@prabhuteja12 prabhuteja12 marked this pull request as ready for review October 9, 2023 09:02
@@ -173,6 +180,14 @@ The following table contains the list of supported datasets.
- multiple
- Any `Hugging Face dataset <https://huggingface.co/datasets>`__ can be used. Just prepend the prefix ``hfd-``, e.g., ``hfd-rotten_tomatoes``. Select input and target columns via ``config_space``, e.g., add ``"input_column": "text", "target_column": "label"`` for the `rotten_tomatoes <https://huggingface.co/datasets/rotten_tomatoes>`__ example.
- Please refer to `the official documentation <https://huggingface.co/datasets>`__.
* - CDDB
- Image Classification
- 2 classes from 5 domains of generated images using various techniques. Numbers vary across domains.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make domains explicit?

"2 classes from 5 domains of generated images using various techniques" this description wouldn't be clear to me. how about this:

  • Image Classification: deepfake detection
  • 2 classes, 5 domains, each representing an image generation technique: ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- 2 classes from 5 domains of generated images using various techniques. Numbers vary across domains.
- Li, Chuqiao, et al. A continual deepfake detection benchmark: Dataset, methods, and essentials. IEEE/CVF Winter Conference on Applications of Computer Vision. 2023.
* - CORe50
- Object Recognition - image classfication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stick to the format used earlier, i.e., Image Classification?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- Image Classification
- 2 classes from 5 domains of generated images using various techniques. Numbers vary across domains.
- Li, Chuqiao, et al. A continual deepfake detection benchmark: Dataset, methods, and essentials. IEEE/CVF Winter Conference on Applications of Computer Vision. 2023.
* - CORe50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to the name we use to load the data as part of benchmarking. Right now, this should be Core50.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- Li, Chuqiao, et al. A continual deepfake detection benchmark: Dataset, methods, and essentials. IEEE/CVF Winter Conference on Applications of Computer Vision. 2023.
* - CORe50
- Object Recognition - image classfication
- 10 classes of 7 training domains, 3 other domains used for evaluation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 8 domains. The 3 other domains is irrelevant for evaluation. Rather mention that there is only 1 test dataset which will be used as test set for each task. Same comment as before "10 classes of 7 training domains". What does that mean? Rather something like "50 classes, 8 domains (0-7)." Note, there are 50 classes, not 10.

@wistuba wistuba merged commit 2e1efce into dev Oct 9, 2023
18 checks passed
@wistuba wistuba deleted the pt_documentation_changes branch October 9, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants