Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws sdk to v1.35.4 #240

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Update aws sdk to v1.35.4 #240

merged 1 commit into from
Nov 12, 2020

Conversation

b-dean
Copy link
Contributor

@b-dean b-dean commented Oct 7, 2020

Description of changes:
I was running into an issue where the credentials from credential_process in my ~/.aws/config were not valid JSON because they were being truncated.

$ docker-credential-ecr-login list
ecr: could not list credentials: ecr: Failed to get authorization token: ProcessProviderParseError: parse failed of credential_process output: {"Version":1,"AccessKeyId":"ASIAxxxxxxxxxxxxxxxxx","SecretAccessKey":"xxxxxxxxxxxx","SessionToken":"xxxx...more...xxxxx
caused by: unexpected end of JSON input

This is fixed in the aws sdk in v1.25.42, but I figured we might as well update to the latest sdk.

This would also fix @fred-vogt's issues in PR #223 and issue #215

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ben Dean <ben.dean@ontariosystems.com>
@rittneje
Copy link

@samuelkarp @kzys @nmeyerhans Can this PR be merged? The version of the SDK currently being used is quite out of date (over a year old). I would like to be able to leverage the AWS_ROLE_ARN environment variable that was added recently.

@kzys
Copy link
Contributor

kzys commented Nov 9, 2020

Looks good to me. Let me sync-up with @samuelkarp.

@kzys kzys merged commit a004738 into awslabs:master Nov 12, 2020
@krmichelos
Copy link

It is great that this has been merged. @kzys or @samuelkarp is there a planned release soon that will contain this change?

@zvymazal
Copy link

@samuelkarp Is there a target date for the next release in which this update will be released?

@kzys
Copy link
Contributor

kzys commented Jan 26, 2021

We don't have the target date yet, but we are going to create a new release which will include this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants