Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instance type networking limits #1153

Merged
merged 1 commit into from
Jan 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 50 additions & 2 deletions files/eni-max-pods.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# express or implied. See the License for the specific language governing
# permissions and limitations under the License.
#
# This file was generated at 2022-09-21T13:34:09-07:00
# This file was generated at 2023-01-25T20:06:57Z
#
# The regions queried were:
# - ap-northeast-1
Expand Down Expand Up @@ -158,6 +158,15 @@ c6id.8xlarge 234
c6id.large 29
c6id.metal 737
c6id.xlarge 58
c6in.12xlarge 234
c6in.16xlarge 737
c6in.24xlarge 737
c6in.2xlarge 58
c6in.32xlarge 345
c6in.4xlarge 234
c6in.8xlarge 234
c6in.large 29
c6in.xlarge 58
c7g.12xlarge 234
c7g.16xlarge 737
c7g.2xlarge 58
Expand Down Expand Up @@ -209,7 +218,7 @@ g5.12xlarge 737
g5.16xlarge 234
g5.24xlarge 737
g5.2xlarge 58
g5.48xlarge 737
g5.48xlarge 345
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, I just ran the VPC CNI script: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/scripts/gen_vpc_ip_limits.go and saw that it pulled a new limit here

Copy link
Member

@Issacwww Issacwww Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the change in pkg/awsutils/vpc_ip_resource_limit.go in this PR, the ENILimit for g5.48xlarge changed from 15 to 7, double confirmed by checking DescribeInstanceTypes API, see the response of NetworkInfo for g5.48xlarge below

 "NetworkInfo": {
              "NetworkPerformance": "100 Gigabit",
              "MaximumNetworkInterfaces": 7,
              "MaximumNetworkCards": 1,
              "DefaultNetworkCardIndex": 0,
              "NetworkCards": [
                  {
                      "NetworkCardIndex": 0,
                      "NetworkPerformance": "100 Gigabit",
                      "MaximumNetworkInterfaces": 7
                  }
              ],
              "Ipv4AddressesPerInterface": 50,
              "Ipv6AddressesPerInterface": 50,
              "Ipv6Supported": true,
              "EnaSupport": "required",
              "EfaSupported": true,
              "EfaInfo": {
                  "MaximumEfaInterfaces": 1
              },
              "EncryptionInTransitSupported": true,
              "EnaSrdSupported": false
          }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thank you for checking!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty odd that this changed, but the API doesn't lie. 👍

g5.4xlarge 234
g5.8xlarge 234
g5.xlarge 58
Expand All @@ -224,6 +233,7 @@ h1.2xlarge 58
h1.4xlarge 234
h1.8xlarge 234
hpc6a.48xlarge 100
hpc6id.32xlarge 51
hs1.8xlarge 234
i2.2xlarge 58
i2.4xlarge 234
Expand Down Expand Up @@ -393,6 +403,24 @@ m6id.8xlarge 234
m6id.large 29
m6id.metal 737
m6id.xlarge 58
m6idn.12xlarge 234
m6idn.16xlarge 737
m6idn.24xlarge 737
m6idn.2xlarge 58
m6idn.32xlarge 345
m6idn.4xlarge 234
m6idn.8xlarge 234
m6idn.large 29
m6idn.xlarge 58
m6in.12xlarge 234
m6in.16xlarge 737
m6in.24xlarge 737
m6in.2xlarge 58
m6in.32xlarge 345
m6in.4xlarge 234
m6in.8xlarge 234
m6in.large 29
m6in.xlarge 58
mac1.metal 234
mac2.metal 234
p2.16xlarge 234
Expand Down Expand Up @@ -525,6 +553,24 @@ r6id.8xlarge 234
r6id.large 29
r6id.metal 737
r6id.xlarge 58
r6idn.12xlarge 234
r6idn.16xlarge 737
r6idn.24xlarge 737
r6idn.2xlarge 58
r6idn.32xlarge 345
r6idn.4xlarge 234
r6idn.8xlarge 234
r6idn.large 29
r6idn.xlarge 58
r6in.12xlarge 234
r6in.16xlarge 737
r6in.24xlarge 737
r6in.2xlarge 58
r6in.32xlarge 345
r6in.4xlarge 234
r6in.8xlarge 234
r6in.large 29
r6in.xlarge 58
t1.micro 4
t2.2xlarge 44
t2.large 35
Expand Down Expand Up @@ -558,7 +604,9 @@ trn1.2xlarge 58
trn1.32xlarge 247
u-12tb1.112xlarge 737
u-12tb1.metal 147
u-18tb1.112xlarge 737
u-18tb1.metal 737
u-24tb1.112xlarge 737
u-24tb1.metal 737
u-3tb1.56xlarge 234
u-6tb1.112xlarge 737
Expand Down