Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #1277 .
Description of changes:
The ECR pattern configured for China regions is incorrect. The domain should be
amazonaws.com.cn
, notamazonaws.cn
. Also opened a PR to fix the k8s docs on this, which is the source of our misconfig: kubernetes/website#40841By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.