Install nerdctl

[ddl-retornam]

Issue #, if available:

Attempts to close #797 in #1234 and #1235 were stalled. This PR is an attempt
to provide a working replacement for the default ctr command bundled with containerd with the nerdctl command
which is officially supported by containerd

Description of changes:

According to the default ctr cli man page bundled with containerd

"ctr is an unsupported debug and administrative client for interacting with the containerd daemon. Because it is unsupported, the commands, options, and operations are not guaranteed to be backward compatible or stable from release to release of the containerd project. "

The nerdctl cli program provided by containerd at
https://github.com/containerd/nerdctl

is meant to be a Docker-compatible CLI for containerd.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

Installed the package on running versions of the amazon-eks-node-* AMI

[cartermckinnon]

Can you add some details about your use case? What do you do with nerdctl on your nodes?

[ddl-retornam]

Can you add some details about your use case? What do you do with nerdctl on your nodes?

There is sometimes the need to debug containers and images on the node directly. The ctr command lacks some functionality like testing direct access to configured registries and the like.

[bryantbiggs]

There is sometimes the need to debug containers and images on the node directly. The ctr command lacks some functionality like testing direct access to configured registries and the like.

I think the key phrase there is sometimes - which means installing it at the time of debugging is preferred over having it installed by default on all AMIs/instances

[ddl-retornam]

I think the key phrase there is sometimes - which means installing it at the time of debugging is preferred over having it installed by default on all AMIs/instances

There have been prior discussions about this in #797 in and attempts were made to close it #1234 and #1235

I think it is prudent for every reviewer to read those prior discussions before commenting on this PR as it would lead to better conversations around this particular PR.

https://github.com/containerd/nerdctl is containterd projects suggested debugging tool instead of the bundled ctr

Thank you

[cartermckinnon]

I tend to agree with @bryantbiggs that we should avoid installing stuff that isn't strictly necessary at runtime, but nerdctl is the blessed CLI for containerd these days. My only concern around installing it is the maintenance of the package in the AL2 repos -- let me follow up internally to figure out how/when that happens.

[ddl-retornam]

I tend to agree with @bryantbiggs that we should avoid installing stuff that isn't strictly necessary at runtime, but nerdctl is the blessed CLI for containerd these days. My only concern around installing it is the maintenance of the package in the AL2 repos -- let me follow up internally to figure out how/when that happens.

Thanks @cartermckinnon. Is there an update here or should I close this PR.

[cartermckinnon]

I think we should install this. But I want to make sure that this package doesn't declare containerd as a dependency; because if we install it before containerd, we might not respect the containerd_version AMI template variable. I'll kick off the CI and see what the yum logs look like.

[cartermckinnon]

Logs look fine, this installs after containerd. 👍

[cartermckinnon]

/ci build

[github-actions]

@cartermckinnon roger that! I've dispatched a workflow. 👍

[github-actions]

@cartermckinnon the workflow that you requested has completed. 🎉

Kubernetes version	Build	Launch	Test
1.23	success ✅	skipped ⏭️	skipped ⏭️
1.24	success ✅	skipped ⏭️	skipped ⏭️
1.25	success ✅	skipped ⏭️	skipped ⏭️
1.26	success ✅	skipped ⏭️	skipped ⏭️
1.27	success ✅	skipped ⏭️	skipped ⏭️

[cartermckinnon]

Logs look fine, this installs after containerd. 👍