Do not prepare local disks by default #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issacwww
approved these changes
Feb 23, 2024
ndbaker1
approved these changes
Feb 23, 2024
Comment on lines
+7
to
+8
| Environment=LOCAL_DISK_STRATEGY=none | ||
| ExecStart=/usr/bin/setup-local-disks $LOCAL_DISK_STRATEGY |
There was a problem hiding this comment.
sounds like we are gonna reuse the EnvironmentFile created via nodeadm approach here?
cartermckinnon
changed the title
atmosx
pushed a commit
to gathertown/amazon-eks-ami
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This makes the
setup-local-disksservice unit on AL2023 a no-op by default. A followup PR will add an option toNodeConfigto set the local disk strategy (or otherwise configure the underlying unit).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.