-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support os_distro and version for CI job #1726
Conversation
I like the change, but don't love the syntax 😛 . What if we used the
|
Fair fair, I will update the syntax |
I think this format would be good, as the later arguments would override the earlier if we pass then in multiple lines, here. Change this to a list is not that necessary as
Tested here |
6e7bc91
to
b411c50
Compare
Parsing multiple args out of a single
Then we can just check if the I think it'll be more common to set only one of these dimensions of the matrix vs. both, so the extra edit: lol triggered the CI |
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
@cartermckinnon the workflow that you requested has completed. 🎉
|
Updated new revision with multi-line arguments, tested here |
* support os_distro and version for CI job * Update bot syntax
* support os_distro and version for CI job * Update bot syntax
Issue #, if available:
Description of changes:
Extend the CI job to accept os_distro and version to be frugal
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
Tested in my folk Issacwww#3
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.