Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry IMDS calls on ECONNREFUSED #1749

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Retry IMDS calls on ECONNREFUSED #1749

merged 1 commit into from
Apr 4, 2024

Conversation

cartermckinnon
Copy link
Member

@cartermckinnon cartermckinnon commented Apr 4, 2024 •
edited
Loading

Description of changes:

curl won't treat ECONNREFUSED as a transient error unless this flag is used.

https://curl.se/docs/manpage.html

In addition to the other conditions, consider ECONNREFUSED as a transient error too for --retry. This option is used together with --retry.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cartermckinnon
Copy link
Member Author

/ci
+workflow:os_distros al2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

@cartermckinnon roger that! I've dispatched a workflow. 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

@cartermckinnon the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.21 / al2success ✅success ✅
1.22 / al2success ✅success ✅
1.23 / al2success ✅success ✅
1.24 / al2success ✅success ✅
1.25 / al2success ✅success ✅
1.26 / al2success ✅success ✅
1.27 / al2success ✅success ✅
1.28 / al2success ✅success ✅
1.29 / al2success ✅success ✅

ndbaker1
ndbaker1 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ndbaker1 ndbaker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship 🚀

@cartermckinnon cartermckinnon merged commit c0d8cd2 into main Apr 4, 2024
9 of 10 checks passed
@cartermckinnon cartermckinnon deleted the imds-connrefused branch April 4, 2024 21:01
atmosx pushed a commit to gathertown/amazon-eks-ami that referenced this pull request Jun 18, 2024
@cartermckinnon @atmosx
Retry IMDS calls on ECONNREFUSED (awslabs#1749)
69da645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndbaker1 ndbaker1 ndbaker1 approved these changes

@Issacwww Issacwww Issacwww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermckinnon @Issacwww @ndbaker1