Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap helper for GPU AMI #1754

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

cartermckinnon
Copy link
Member

@cartermckinnon cartermckinnon commented Apr 5, 2024

Issue #, if available:

This is part of the fix for a race-condition occurring in the GPU, referenced in: #1744.

Description of changes:

We need a way to explicitly synchronize some background processes that configure GPU instances in the GPU AMI. This will run a helper script if it's present, which will perform GPU-AMI-specific actions. The helper script will only be present on GPU AMI's.

As the code comment states, this is not intended to be a way for users to inject arbitrary logic into the bootstrap script! Don't do that.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cartermckinnon
Copy link
Member Author

/ci
+workflow:os_distros al2

Copy link
Contributor

github-actions bot commented Apr 5, 2024

@cartermckinnon roger that! I've dispatched a workflow. 👍

Copy link
Contributor

github-actions bot commented Apr 5, 2024

@cartermckinnon the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.21 / al2success ✅success ✅
1.22 / al2success ✅success ✅
1.23 / al2success ✅success ✅
1.24 / al2success ✅success ✅
1.25 / al2success ✅success ✅
1.26 / al2success ✅success ✅
1.27 / al2success ✅success ✅
1.28 / al2success ✅success ✅
1.29 / al2success ✅success ✅

@cartermckinnon cartermckinnon merged commit f55411c into main Apr 5, 2024
9 of 10 checks passed
@cartermckinnon cartermckinnon deleted the bootstrap-gpu-helper branch April 5, 2024 23:45
@cartermckinnon cartermckinnon restored the bootstrap-gpu-helper branch April 8, 2024 18:27
atmosx pushed a commit to gathertown/amazon-eks-ami that referenced this pull request Jun 18, 2024
@ndbaker1 ndbaker1 deleted the bootstrap-gpu-helper branch September 2, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants