Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #673 by updating eni-max-pods.txt #676

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Conversation

mmerkes
Copy link
Member

@mmerkes mmerkes commented Jun 8, 2021

Issue #, if available:

#673

Description of changes:

Updates the eni-max-pods.txt file to include the latest instances available with EC2. Followed user guide in repo.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vishalkg
Copy link
Contributor

vishalkg commented Jun 8, 2021

Can we include the these instances in in this file too. Also, can we check if we have any instance missing in the above mentioned file against the eni-max-pods.txt

@mmerkes
Copy link
Member Author

mmerkes commented Jun 8, 2021

@vishalkg Tx for the review. I've updated the file you mention. I just merged all the instance types.

@vishalkg
Copy link
Contributor

vishalkg commented Jun 8, 2021

LGTM

@mmerkes mmerkes merged commit 3616f1d into awslabs:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants