Applying Backoff for rate-limited Maven Downloads in setup.py #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-backoff-for-maven Jf/applying backoff for maven
…ng-backoff-for-maven incrementing version number
…ng-backoff-for-maven Applying changes to master
ghost
changed the title
ghost
mentioned this pull request
|
Hi, would love to get this merged! Who do we tag to make this happen? |
|
Willing to help with this PR as well. @avahuang0429 anything we can do to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #99
Description of changes:
When a 429 response is received when attempting to download one of the jars, this will apply exponential backoff, sleeping anywhere between 1 second (on the first retry) to 16 (on the final retry).
This PR is meant to replace PR #100. I no longer work at that company so I can't update that branch on the repository any more.
I've updated the branch to fix the version number and apply the feedback that has been requested. I'd like to see this change applied, since my new company is likely to use this library and I'd like to have this issue resolved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.