Make maven repository configurable via an env var #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shanmsac Would you mind reviewing this minor change please? |
|
@akidambisrinivasan @brendan-p-lynch @furq-aws Tagging you as recent reviewers on this repo, would one of you mind taking a look at this change please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Maven repository configurable via an env var, default to public Maven repo
Issue number:
#209
Description of changes:
Currently
python setup.py download_jarsis hardcoded to download the KCL jars from the public Maven repository. This change makes the Maven repository configurable via an env var (defaulting to public Maven if not set). This will allow this package to be installed directly via a pip install for anyone using their own Maven repository.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.