Don't Restart From Scratch on DescribeStream Failures #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the handling of describe stream throttling by no longer triggering a null pointer exception when all requests are throttled. Also store the last position reached, and always restart from there.
Changed the shard iterator reset to simply recreate the iterator.
Updated to a newer version of the DynamoDB Local library, and updated the repository location.
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Apr 7, 2017
* Correctly handle throttling for DescribeStream, and save accumulated progress from individual calls. * PR awslabs#152 * Upgrade to version 1.11.115 of the AWS Java SDK * PR awslabs#155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the if a DescribeStream call fails, or is completely throttled any intermediate state will be lost. This requires that the next attempt start at the beginning. For large streams this may trigger additional throttling of calls to DescribeStream.